Transition to valtrees pt1

[b-naber]

Compartmentalising #96591 as much as possible.

r? @oli-obk

[rust-highfive]

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

[rust-highfive]

⚠️ Warning ⚠️

• These commits modify submodules.

[b-naber]

I'm not sure why I get the changes in the submodules. Something must have gone wrong during a rebase, I had some conflicts in submodules and used get reset master submodule_path to resolve those, which might have been the wrong way to fix those. Does anybody know how to fix this?

[RalfJung]

Figure out in which commit the submodule change is, and then use rebase --interactive to edit that commit and get rid of the submodule change.

[b-naber]

Updated the submodule and squashed with the commit that previously had the submodule change. Still have a change in the submodule's Cargo.lock file according to the diff though.

[oli-obk]

I went afk mid review and forgot to send it. Will continue on Monday.

[bors]

☔ The latest upstream changes (presumably #97013) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

needs a rebase.

Also you got a submodule update somewhere in there, please make sure to remove it during the rebase

[oli-obk]

r=me after that

[oli-obk]

Please squash the commits so there's no back and forth with the submodule

[b-naber]

@oli-obk Can you take another look, please?

[oli-obk]

@bors r+

[bors]

📌 Commit 96b36d6 has been approved by oli-obk

[bors]

⌛ Testing commit 96b36d6 with merge cd282d7...

[bors]

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing cd282d7 to master...

[rust-timer]

Finished benchmarking commit (cd282d7): comparison url.

Summary:

• Primary benchmarks: 😿 relevant regressions found
• Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count1	4	5	0	0	4
mean2	1.0%	0.1%	N/A	N/A	1.0%
max	1.1%	0.1%	N/A	N/A	1.1%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

1. number of relevant changes ↩

2. the arithmetic mean of the percent change ↩

[oli-obk]

cachegrind on the unicode-normalization regression:

-97,176,447  ???:rustc_mir_build::thir::pattern::compare_const_vals
 72,480,660  ???:<rustc_middle::mir::interpret::value::ConstValue>::try_to_bits
 54,411,647  ???:<rustc_mir_build::build::Builder>::match_simplified_candidates
-37,703,135  ???:<rustc_mir_build::build::Builder>::test_candidates_with_or
 20,818,165  ???:<rustc_middle::mir::ConstantKind>::ty
 18,643,459  ???:<rustc_mir_build::build::Builder>::values_not_contained_in_range
  9,696,591  ???:<rustc_mir_build::build::Builder>::simplify_candidate
 -4,265,882  ???:rustc_mir_build::build::expr::as_constant::lit_to_mir_constant
  2,721,211  ???:<rustc_mir_build::build::Builder>::as_constant

could probably benefit from some targeted #[inline(always)] instructions (try_to_bits and ConstantKind::ty maybe?)