Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more targeted suggestion when confusing i8 with std::i8 #97845

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Jun 7, 2022

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 7, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2022
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 7, 2022

📌 Commit 8542dd0 has been approved by compiler-errors

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2022
@compiler-errors
Copy link
Member

(also I love the branch name)

bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2022
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#97829 (Add regresion test for rust-lang#95307)
 - rust-lang#97831 (Remove `AlwaysLiveLocals` wrapper struct)
 - rust-lang#97832 (Change `Direction::{is_forward,is_backward}` functions into constants)
 - rust-lang#97840 (RustWrapper: adapt to APInt API changes in LLVM 15)
 - rust-lang#97845 (Use more targeted suggestion when confusing i8 with std::i8)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2d8485 into rust-lang:master Jun 8, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants