Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustdoc-json regression test for #98009 #98166

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #98009.

There was apparently nothing to be done...

cc @matthiaskrgr
r? @notriddle

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 16, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2022
@GuillaumeGomez GuillaumeGomez added the A-rustdoc-json Area: Rustdoc JSON backend label Jun 16, 2022
@matthiaskrgr
Copy link
Member

👍 can confirm that this is fixed in master

@GuillaumeGomez
Copy link
Member Author

Then let's go!

@bors r=matthiaskrgr rollup

@bors
Copy link
Contributor

bors commented Jun 16, 2022

📌 Commit d751314 has been approved by matthiaskrgr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 16, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97377 (Do not suggest adding semicolon/changing delimiters for macros in item position that originates in macros)
 - rust-lang#97675 (Make `std::mem::needs_drop` accept `?Sized`)
 - rust-lang#98118 (Test NLL fix of bad lifetime inference for reference captured in closure.)
 - rust-lang#98166 (Add rustdoc-json regression test for rust-lang#98009)
 - rust-lang#98169 (Keyword docs: Link to wikipedia article for dynamic dispatch)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 81b00b8 into rust-lang:master Jun 17, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 17, 2022
@GuillaumeGomez GuillaumeGomez deleted the regression-test-98009 branch June 17, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc json ice: assertion failure: different Output: Generics
6 participants