fix oboe wrapping struct field comments #6242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytmimi
requested changes
Jul 18, 2024
| let item_shape = Shape::indented(offset, context.config).sub_width(1)?; | ||
| let item_shape = Shape::indented(offset, context.config).sub_width(0)?; |
There was a problem hiding this comment.
I don't think this is the correct approach. First because CI is failing, but also because we .sub_width(1) to make sure that the field + trailing comma doesn't exceed the max_width. I think you'll need to look a little deeper into this to understand what shape gets used to rewrite the comments.
There was a problem hiding this comment.
@ytmimi Thanks for the review. Will try to look deeper into this issue!
There was a problem hiding this comment.
feel free to reach out here or on Zulip if you have any questions
|
Going to close this as we're not moving forward with this PR as currently implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6180