Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warning about clone implementation #44

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

phil-opp
Copy link
Member

Read-only VolatileRef instances implement Copy, so we should set the Clone implementation to just *self to ensure that Clone and Copy match. See https://rust-lang.github.io/rust-clippy/master/index.html#/non_canonical_clone_impl .

@phil-opp phil-opp merged commit d2d2239 into main Mar 22, 2024
8 of 10 checks passed
@phil-opp phil-opp deleted the fix-clippy-warning branch March 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant