feat: introduce RestrictAccess<To> and generalize restrict to all access types
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Nice abstraction! It makes things a bit more complex, but also more flexible.
I think it would be a good idea to do the breaking release quickly and remove the associated RestrictShared type. Otherwise I fear that the two ways to restrict access could lead to confusion. What do you think?
Ready for merge from my side after a rebase.
phil-opp
reviewed
Apr 26, 2024
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
…irectly Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
…stent Signed-off-by: Martin Kröning <[email protected]>
Works for me. I rebased, removed |
mkroening
force-pushed
the
general-restrict
branch
from
0ac779e
to
c64c9af
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
trait RestrictAccess<T>to generalize the restriction from any access type to any other access type, to implementVolatile{Ptr,Ref}::restrictgenerically for all access types.While not required, this PR also replaces and deprecates
Access::RestrictShared, since it is equivalent toRestrictAccess<ReadOnly>::Restricted.Though also optional, I implemented
Readable,Writable, andCopyablein terms ofRestrictAccess.This PR depends on #59.