Add reusable counterpart of WeightedIndex #1460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maratik123
commented
Jun 16, 2024
| /// Just a wrapper to surround internal persistent storage to reuse in [`ReusableWeightedIndex`] | ||
| /// instances. | ||
| #[derive(Debug, Clone, PartialEq)] | ||
| pub struct CumulativeWeightsWrapper<X> { |
There was a problem hiding this comment.
May be it will be useful to replace it with slice container to allow somebody to use stack-allocated container (via smallvec for example). But it will require additional checks on filling with weights
|
Status: counter-proposals; see #1459. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Add reusable counterpart of
WeightedIndexMotivation
This solves #1459
Details
Add new module to implement
ReusableWeightedIndex