normalize_stdout: reset alignment on new lines #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code never resets alignment and so fails with cases like `echo '1\t2\n\t3'`, which both `expand` and `watch` handle just fine. This should fix that, but note that the current code can still be tripped up by escape sequences etc. (`echo '\e[0m1\t2\n\t3'`, for example) -- interestingly while `expand` trips up similar to the current code, `watch --color` handles these perfectly.
|
I haven't looked at it closely yet but for posterity, the code at https://github.com/mgeisler/textwrap/blob/63970361d1d653ec8715acb931c3c109750d4a57/src/core.rs#L52 seems to be useful for making this work with escape codes (and possibly unicode characters?). |
|
@avamsi Thank you! That may solve our problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code never resets alignment and so fails with cases like
echo '1\t2\n\t3', which bothexpandandwatchhandle just fine.This should fix that, but note that the current code can still be
tripped up by escape sequences etc. (
echo '\e[0m1\t2\n\t3', forexample) -- interestingly while
expandtrips up similar to the currentcode,
watch --colorhandles these perfectly.