Set EastAsianWidth to fix broken layout #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egawata
changed the title
|
Sorry for late. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box layout in the top of screen is broken when using CJK locales.
The following is a screenshot, using MacOS 12.4, iTerm2 3.4.16, and
LANG=ja_JP.UTF-8The first letter of titles aren't displayed, and box layout is broken.
The reason is that those box-drawing characters are ambiguous width ones, which will be displayed with a narrow width with non-CJK locales, but with wide width with CJK, which would break layout.
One way to fix it is to override
DefaultCondition.EastAsianWidthvariable ingo-runewidthwithfalse, so that any ambiguous width charactes would always be displayed with narrow width.