Sympy minus infinity doesn't convert to Sage #12345
Comments
|
Changed keywords from none to sd40.5 |
|
comment:1
Straightforward fix and test of the original case as an integral. |
|
comment:2
Umm, even without this patch I get Am I missing something? How is that an indirect doctest? That said, the integral works fine now and the tests pass. |
|
Reviewer: Karl-Dieter Crisman |
|
Author: Douglas McNeil |
|
comment:3
Ah, those were merely mirroring the +oo cases. Really they were only testing whether the negation worked; it was the integral test which was really verifying the success. However, we can test it explicitly by adding. which fails without the patch. Modified to incorporate this. |
|
comment:4
Positive review. |
|
Attachment: trac_12345_minusinfinity_sympyfication.patch.gz add |
|
Merged: sage-5.1.beta4 |
|
comment:7
I think this ticket is already fixed? |
|
Commit: |
37 tasks
Closed
vbraun
pushed a commit
that referenced
this issue
Mar 26, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> ### 📚 Description Made small edits to the PR template, making it concise and tidy overall. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on Depends on #12345: short description why this is a dependency Depends on #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35141 Reported by: Kwankyu Lee Reviewer(s): Kwankyu Lee, Tobias Diez
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description Partial fix for pycodestyle E221, done using autopep8. E221 multiple spaces before operator <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35355 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description The update #35184 broke the docs upload. Hopefully this is fixed with this PR. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35356 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik, Kwankyu Lee
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Follow-up from #35322. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35366 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description This is a follow-up on: - #35110 As preparation for #35322, which is changing more packages to implicit namespace packages, we remove `.all` imports from these packages throughout the Sage library. This is part of: - #29705 <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> - Depends on #35418 - Depends on #35358 <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35372 Reported by: Matthias Köppe Reviewer(s): Gonzalo Tornaría
vbraun
pushed a commit
that referenced
this issue
Apr 6, 2023
<!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description openblas 0.3.22 is broken, see: - #35371 - scipy/scipy#18208 - OpenMathLib/OpenBLAS#3976 We reject it. <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35377 Reported by: Matthias Köppe Reviewer(s): John H. Palmieri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Rebased and updated from sagemath#30564. Fixes sagemath#30564 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38522 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> See added comments for details. - Example of GitHub workflow commands that take action again thanks to stripping the timestamps: The folding of output seen in https://github. com/mkoeppe/sage/actions/runs/10438847625/job/28906649046#step:11:3839 ### :memo: Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### :hourglass: Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38523 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Fixes sagemath#38531 Tests at https://github.com/mkoeppe/sage/actions/runs/10464240837/job/28977512582 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38534 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
Fixes sagemath#38527. This PR makes the comparison of edges more robust in `spqr_tree_to_graph`, so that edges `(u, v, label)` and `(v, u, label)` are no longer considered as distinct edges. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38535 Reported by: David Coudert Reviewer(s): cyrilbouvier
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
That's what the code appear to be doing. The existing example in `_compute_periods_real` also show it: ```sage sage: sage: # needs sage.rings.number_field ....: sage: x = polygen(ZZ, 'x') ....: sage: K.<a> = NumberField(x^3 - 2) ....: sage: E = EllipticCurve([0,1,0,a,a]) ....: sage: embs = K.embeddings(CC) ....: sage: Ls = [E.period_lattice(e) for e in embs] ....: sage: [L.is_real() for L in Ls] ....: [False, False, True] sage: sage: Ls[2]._compute_periods_real(100) ....: (3.8145297721785450936365098936, 1.9072648860892725468182549468 + 1.3404778596244020196600112394*I) ``` Then do ```sage sage: ω1, ω2 = _ sage: ω2/ω1 0.50000000000000000000000000000 + 0.35141365769412556448697319411*I sage: ω1/ω2 1.3387183410189190672591156778 - 0.94088781767934015952275257142*I ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38561 Reported by: user202729 Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38563 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [X] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38566 Reported by: grhkm21 Reviewer(s): grhkm21, Vincent Macri
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Aug 28, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Removing the notice on the transition to GitHub from the Developer Guide, as well as two small traces in other documentation. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38567 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> As noted in sagemath#36046 (comment), `sage -t --valgrind` does not work because it instruments the wrong process. As part of the fix, we move the contents of `src/bin/sage-runtests` to `src/bin/sage/doctest/__main__.py` so that the doctester can be invoked as `sage -python -m sage.doctest`. We also arrange for `sage -t --valgrind` to use the suppressions file added in sagemath#36046. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37569 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
…cleanup
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The goal of this PR is twofold:
First, we fix the category of modular forms ring as per PR sagemath#37797 to
make the following code work:
```
sage: M = ModularFormsRing(1)
sage: M['z', 'w']
Multivariate Polynomial Ring in z, w over Ring of Modular Forms for
Modular Group SL(2,Z) over Rational Field
```
Second, we do a documentation and PEP8 cleanup of the class
`ModularFormsRing`.
CC: @fchapoton
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37821
Reported by: David Ayotte
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
…mial of the Frobenius endomorphism of a Drinfeld module
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This pull request implements two new algorithms to compute the
characteristic polynomial of the Frobenius endomorphism of a Drinfeld
$\mathbb F_q[T]$-module over a finite field $K$. Previously, only the
algorithms based on crystalline cohomology (see [Musleh-Schost
2023](https://dl.acm.org/doi/10.1145/3597066.3597080)) or on Anderson
motives (see [Caruso-Leudière 2023](https://arxiv.org/abs/2307.02879))
were implemented. We propose two new algorithms:
- The algorithm based on central simple algebras described in Chapter 4
of [Caruso-Leudière 2023](https://arxiv.org/abs/2307.02879).
- The algorithm described by Gekeler in [Gekeler 1991](https://www.scien
cedirect.com/science/article/pii/002186939190211P).
**Acknowledgement.** This implementation was originally due to @xcaruso
(see [here](https://github.com/xcaruso/sage/blob/d2e36bd18b51c93806b7a3b
5c8261da7dc98c494/src/sage/rings/function_field/drinfeld_modules/finite_
drinfeld_module.py)), and after a private discussion, I took the liberty
of creating this PR.
I also propose to change the formula computed by `frobenius_norm`.
Before, it computed
$$(-1)^n \mathrm{N}_{K/\mathbb F_q}(\Delta) p^{n / \mathrm{deg}(p)},$$
where $K$ is the ground field, $n$ is the degree of $K$ over $\mathbb
F_q$, and $p$ is the monic generator of the $\mathbb
F_q[T]$-characteristic of $K$. The docstring claimed this was $(-1)^r$
times the constant coefficient of the characteristic polynomial of the
Frobenius endomorphism, $r$ being the rank of the Drinfeld module. I
believe this was a mistake, and instead changed the formula, following
Theorem 4.2.7 of [Papikian's
book](https://link.springer.com/book/10.1007/978-3-031-19707-9), to
$$(-1)^{nr - n - r} \mathrm{N}_{K/\mathbb F_q}(\Delta) p^{n /
\mathrm{deg}(p)}.$$
P.S. @DavidAyotte, given that you now work in the industry, please tell
us if you still want to be tagged on these Drinfeld module stuff. Same
question for you @ymusleh given that you defended your thesis
(congratulations!).
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
(Dédicace à ABLCCN)
URL: sagemath#38174
Reported by: Antoine Leudière
Reviewer(s): Antoine Leudière, David Ayotte, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> As proposed in https://groups.google.com/g/sage-devel/c/pj76chTb348 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38532 Reported by: Matthias Köppe Reviewer(s): Nathan Dunfield
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38548 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
… tours links
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The release tours are now accessed through GitHub Releases.
This is the next step of:
- sagemath#31533
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38581
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
… build
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#37664.
from the log of the doc build workflow of this PR,
```
[sagemath_doc_html-none] [spkg-install] sage --docbuild --no-pdf-links
reference/cryptography inventory
[sagemath_doc_html-none] [spkg-install] [cryptogra] Converting
`source_suffix = '.rst'` to `source_suffix = {'.rst':
'restructuredtext'}`.
[sagemath_doc_html-none] [spkg-install] [cryptogra] building
[inventory]: targets for 25 source files that are out of date
[sagemath_doc_html-none] [spkg-install] [cryptogra] updating
environment: [new config] 25 added, 0 changed, 0 removed
[sagemath_doc_html-none] [spkg-install] [cryptogra] The inventory file
is in ../../local/share/doc/sage/inventory/en/reference/cryptography.
[sagemath_doc_html-none] [spkg-install] sage --docbuild --no-pdf-links
reference/curves inventory
```
This PR is based on sagemath#38580 and replaces it. Thank @thecaligarmo for
allowing this arrangement.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38608
Reported by: Kwankyu Lee
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
because pycodestyle is not happy with some allowed use of formatted strings.. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38609 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 5, 2024
This is activating the fix for E303 too many blank lines in all pyx files. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38610 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> As noted in sagemath#36046 (comment), `sage -t --valgrind` does not work because it instruments the wrong process. As part of the fix, we move the contents of `src/bin/sage-runtests` to `src/bin/sage/doctest/__main__.py` so that the doctester can be invoked as `sage -python -m sage.doctest`. We also arrange for `sage -t --valgrind` to use the suppressions file added in sagemath#36046. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37569 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
…cleanup
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The goal of this PR is twofold:
First, we fix the category of modular forms ring as per PR sagemath#37797 to
make the following code work:
```
sage: M = ModularFormsRing(1)
sage: M['z', 'w']
Multivariate Polynomial Ring in z, w over Ring of Modular Forms for
Modular Group SL(2,Z) over Rational Field
```
Second, we do a documentation and PEP8 cleanup of the class
`ModularFormsRing`.
CC: @fchapoton
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#37821
Reported by: David Ayotte
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
…mial of the Frobenius endomorphism of a Drinfeld module
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This pull request implements two new algorithms to compute the
characteristic polynomial of the Frobenius endomorphism of a Drinfeld
$\mathbb F_q[T]$-module over a finite field $K$. Previously, only the
algorithms based on crystalline cohomology (see [Musleh-Schost
2023](https://dl.acm.org/doi/10.1145/3597066.3597080)) or on Anderson
motives (see [Caruso-Leudière 2023](https://arxiv.org/abs/2307.02879))
were implemented. We propose two new algorithms:
- The algorithm based on central simple algebras described in Chapter 4
of [Caruso-Leudière 2023](https://arxiv.org/abs/2307.02879).
- The algorithm described by Gekeler in [Gekeler 1991](https://www.scien
cedirect.com/science/article/pii/002186939190211P).
**Acknowledgement.** This implementation was originally due to @xcaruso
(see [here](https://github.com/xcaruso/sage/blob/d2e36bd18b51c93806b7a3b
5c8261da7dc98c494/src/sage/rings/function_field/drinfeld_modules/finite_
drinfeld_module.py)), and after a private discussion, I took the liberty
of creating this PR.
I also propose to change the formula computed by `frobenius_norm`.
Before, it computed
$$(-1)^n \mathrm{N}_{K/\mathbb F_q}(\Delta) p^{n / \mathrm{deg}(p)},$$
where $K$ is the ground field, $n$ is the degree of $K$ over $\mathbb
F_q$, and $p$ is the monic generator of the $\mathbb
F_q[T]$-characteristic of $K$. The docstring claimed this was $(-1)^r$
times the constant coefficient of the characteristic polynomial of the
Frobenius endomorphism, $r$ being the rank of the Drinfeld module. I
believe this was a mistake, and instead changed the formula, following
Theorem 4.2.7 of [Papikian's
book](https://link.springer.com/book/10.1007/978-3-031-19707-9), to
$$(-1)^{nr - n - r} \mathrm{N}_{K/\mathbb F_q}(\Delta) p^{n /
\mathrm{deg}(p)}.$$
P.S. @DavidAyotte, given that you now work in the industry, please tell
us if you still want to be tagged on these Drinfeld module stuff. Same
question for you @ymusleh given that you defended your thesis
(congratulations!).
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [X] The title is concise and informative.
- [X] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [X] I have created tests covering the changes.
- [X] I have updated the documentation and checked the documentation
preview.
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
(Dédicace à ABLCCN)
URL: sagemath#38174
Reported by: Antoine Leudière
Reviewer(s): Antoine Leudière, David Ayotte, Xavier Caruso
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
…ia an extended LexBFS algorithm
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
This PR implements a new graph decomposition: slice decomposition.
Precise definition and a description of the algorithm can be found in
[TCHP2008 (section 3.2 & 3.3)](https://arxiv.org/pdf/0710.3901v3).
I implemented a new method (only for undirected graphs) called
`slice_decomposition`. It returns a new class `SliceDecompostion`, with
methods to retrieve the information about the computed slice
decomposition.
The code is in a new file:
`graph_decompositions/slice_decomposition.pyx`.
The actual computation is done with a new function called
`extended_lex_BFS` which only works for undirected graphs. It is very
close to the previous `lex_BFS_fast_short_digraph` from
`traversals.pyx`, the difference being that the new function works with
the `CGraph` directly (no conversion needed to `short_digraph` anymore)
and it computes more information (lexicographic labels and length of
x-slices). The complexity of the two algorithms are the same.
So I removed `lex_BFS_fast_short_digraph` from `traversals.pyx` and
used `extended_lex_BFS` instead for the "fast" version of the `lex_BFS`
method.
I took the opportunity to factorize the code between `lex_BFS` ("slow"
version), `lex_DFS`, `lex_UP` and `lex_DOWN`
in `traversals.pyx`: there is no more conversion to `short_digraph` and
they all call the same common function
(remark: i was not able to put the doc in common, so there is still some
repetition between the doc of these methods)
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38299
Reported by: cyrilbouvier
Reviewer(s): cyrilbouvier, David Coudert
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
Similarly to sagemath#38418, this PR adds a method to check whether a set of edges forms an edge cut of the (di)graph, that is if the removal of these edges increases the number of (weakly) connected components. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38435 Reported by: David Coudert Reviewer(s): David Coudert, Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> As proposed in https://groups.google.com/g/sage-devel/c/pj76chTb348 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38532 Reported by: Matthias Köppe Reviewer(s): Nathan Dunfield
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38548 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The changed file, `m4/pyproject_toml_metadata.m4`, controls the metadata of the modularized distributions. The same changes should be done to **sagemath-standard** and **sage- conf** after sagemath#37902, sagemath#36561 are merged. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38577 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
… tours links
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
The release tours are now accessed through GitHub Releases.
This is the next step of:
- sagemath#31533
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38581
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
… build
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
Fixes sagemath#37664.
from the log of the doc build workflow of this PR,
```
[sagemath_doc_html-none] [spkg-install] sage --docbuild --no-pdf-links
reference/cryptography inventory
[sagemath_doc_html-none] [spkg-install] [cryptogra] Converting
`source_suffix = '.rst'` to `source_suffix = {'.rst':
'restructuredtext'}`.
[sagemath_doc_html-none] [spkg-install] [cryptogra] building
[inventory]: targets for 25 source files that are out of date
[sagemath_doc_html-none] [spkg-install] [cryptogra] updating
environment: [new config] 25 added, 0 changed, 0 removed
[sagemath_doc_html-none] [spkg-install] [cryptogra] The inventory file
is in ../../local/share/doc/sage/inventory/en/reference/cryptography.
[sagemath_doc_html-none] [spkg-install] sage --docbuild --no-pdf-links
reference/curves inventory
```
This PR is based on sagemath#38580 and replaces it. Thank @thecaligarmo for
allowing this arrangement.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38608
Reported by: Kwankyu Lee
Reviewer(s): Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
because pycodestyle is not happy with some allowed use of formatted strings.. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38609 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Sep 6, 2024
This is activating the fix for E303 too many blank lines in all pyx files. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38610 Reported by: Frédéric Chapoton Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See this ask.sagemath.org question for background.
CC: @certik @rwst
Component: symbolics
Keywords: sd40.5
Author: Douglas McNeil
Branch/Commit: u/akhi/sympy_minus_infinity_doesn_t_convert_to_sage @
52db42bReviewer: Karl-Dieter Crisman
Merged: sage-5.1.beta4
Issue created by migration from https://trac.sagemath.org/ticket/12345
The text was updated successfully, but these errors were encountered: