Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/checkout from 3 to 4 #47

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 4, 2023

Bumps actions/checkout from 3 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.0.0

v3.6.0

v3.5.3

v3.5.2

v3.5.1

v3.5.0

v3.4.0

v3.3.0

v3.2.0

v3.1.0

v3.0.2

v3.0.1

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Sep 4, 2023
@saidsef
Copy link
Owner

saidsef commented Sep 4, 2023

🤖
The PR is about updating the version of actions/checkout from 3 to 4 in the GitHub workflows. This is a major version update, so it's important to ensure that it doesn't introduce breaking changes.

Looking at the changes in the files, the version of actions/checkout is updated in three workflow files: docker.yml, release.yml, and tagging.yml.

Here are the changes in each file:

  1. docker.yml: The version of actions/checkout is updated from 3 to 4 in two places. No other changes are made.

  2. release.yml: The version of actions/checkout is updated from 3 to 4. No other changes are made.

  3. tagging.yml: The version of actions/checkout is updated from 3 to 4. No other changes are made.

There are no apparent issues with the changes in the PR. However, it's recommended to test the workflows to ensure that the update doesn't break anything.

Here is a suggestion for improvement:

Since the version of actions/checkout is used in multiple places, it would be better to define it in one place and reference it in the workflow files. This would make it easier to manage and update the version in the future.

For example, you could define the version in a versions.yml file:

checkout: 4

And then reference it in the workflow files:

uses: actions/checkout@${{ env.checkout }}

This would require adding a step to each workflow to load the versions:

- name: Load versions
  run: echo "checkout=$(yq e .checkout versions.yml)" >> $GITHUB_ENV

This requires the yq command, which can be installed in a setup step:

- name: Setup
  run: |
    sudo snap install yq

In summary, the PR is fine as it is, but it would be better to centralise the version definitions to make future updates easier.

> gpt-4

@saidsef saidsef self-assigned this Sep 10, 2023
Copy link
Owner

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saidsef saidsef merged commit f9c4816 into main Sep 10, 2023
3 of 4 checks passed
@saidsef saidsef deleted the dependabot-github_actions-actions-checkout-4 branch September 10, 2023 21:59
saidsef pushed a commit that referenced this pull request Sep 28, 2023
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant