Split giant cookie.ts into multiple files. #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
previously approved these changes
Sep 1, 2023
colincasey
dismissed
their stale review
The merge-base changed after approval.
colincasey
previously approved these changes
Sep 1, 2023
wjhsf
dismissed
colincasey’s stale review
The merge-base changed after approval.
colincasey
previously approved these changes
Sep 1, 2023
wjhsf
dismissed
colincasey’s stale review
The merge-base changed after approval.
colincasey
approved these changes
Sep 1, 2023
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
colincasey
added a commit
that referenced
this pull request
Feb 23, 2024
When #296 was merged, the list of files to include in `package.json` was not updated. This PR fixes that. The `.npmignore` file is also removed because I find it causes some unexpected behaviors like ignoring the contents of `.gitignore`. It's a bit of extra work to maintain the allow listed `files` but it's generally safer.
colincasey
added a commit
that referenced
this pull request
Feb 29, 2024
When #296 was merged, the list of files to include in `package.json` was not updated. This PR fixes that. The `.npmignore` file is also removed because I find it causes some unexpected behaviors like ignoring the contents of `.gitignore`. It's a bit of extra work to maintain the allow listed `files` but it's generally safer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cookie.tsandcookieJar.ts(and some test files) are still over that limit, so there's still some refactoring work to do. This PR is focused on just separating things that could be cleanly separated. (For example,Cookie.parseandCookie.fromJSONcould be separated, but that would introduce files with circular dependencies, so I left them for now.)index.tsmatch those from the oldcookie.ts.