-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #256 #297
fix #256 #297
Conversation
and therefore removing the trailing slash
Thanks for the contribution! Before we can merge this, we need @hrueger to sign the Salesforce Inc. Contributor License Agreement. |
I signed the CLA, but then I got an error. Can you please recheck? |
Hm, did I break the tests? That's strange... |
@hrueger -- can you try signing the CLA again? :) Hope you are doing well! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me; but there's a file conflict. Can you please update your pull request @hrueger? Thank you!
@awaterma Now that the project is written in typescript, I get ts errors when importing from that javascript file since the
|
@hrueger it seems like the userland My suggested workaround would be to:
And, since we only use a very small part of the API from |
@colincasey I submitted a PR to DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#68273 |
@colincasey My DefinitelyTyped PR was merged earlier today, so I updated the package and now the types should be fine 🎉 |
by importing
.js
file and therefore removing the trailing slashI'm also using Svelte Kit and currently patching this via
yarn patch
.