Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest TypeScript version #423

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Use latest TypeScript version #423

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
32e0549
bump typescript version and other deps
wjhsf Jun 21, 2024
7b8519a
linter fixes due to better type inference
wjhsf Jun 21, 2024
e92c1e1
use latest eslint
wjhsf Jun 21, 2024
0b161b5
downgrade eslint
wjhsf Jun 21, 2024
c76831f
regenerate docs
wjhsf Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/cookie/cookieJar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ export class CookieJar {
cookies = cookies.filter(matchingCookie)

// sorting of S5.4 part 2
if (options && 'sort' in options && options.sort !== false) {
if ('sort' in options && options.sort !== false) {
cookies = cookies.sort(cookieCompare)
}

Expand Down Expand Up @@ -1474,7 +1474,7 @@ export class CookieJar {

completedCount++

if (completedCount === cookies?.length) {
if (completedCount === cookies.length) {
if (removeErrors[0]) cb(removeErrors[0])
else cb(null, undefined)
return
Expand Down
Loading
Loading