Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault_ssh modules #64

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Add vault_ssh modules #64

merged 2 commits into from
Jul 25, 2024

Conversation

lkubb
Copy link
Member

@lkubb lkubb commented May 14, 2024

What does this PR do?

Adds execution, state and wrapper modules for the SSH secret backend.

What issues does this PR fix or reference?

Fixes: #58

Merge requirements satisfied?

Commits signed with GPG?

Yes

@lkubb lkubb force-pushed the vault-ssh branch 2 times, most recently from 76edb2c to b44a54f Compare May 15, 2024 00:03
@lkubb lkubb force-pushed the vault-ssh branch 4 times, most recently from 3c1bdbf to 4954b14 Compare July 23, 2024 10:08
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 11.63793% with 205 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (e5a0de8) to head (4954b14).
Report is 4 commits behind head on main.

Files Patch % Lines
src/saltext/vault/modules/vault_ssh.py 11.63% 205 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   90.53%   88.93%   -1.60%     
==========================================
  Files          66       67       +1     
  Lines       11092    11325     +233     
  Branches     1406     1221     -185     
==========================================
+ Hits        10042    10072      +30     
- Misses        830     1032     +202     
- Partials      220      221       +1     
Flag Coverage Δ
Linux 88.93% <11.63%> (-1.60%) ⬇️
project 77.67% <11.63%> (-3.98%) ⬇️
py310 ?
py39 88.93% <11.63%> (?)
salt_3006_8 88.93% <11.63%> (-1.58%) ⬇️
salt_3007_1 ?
tests 95.34% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkubb lkubb marked this pull request as ready for review July 25, 2024 12:47
@lkubb lkubb merged commit 2f21851 into salt-extensions:main Jul 25, 2024
17 checks passed
@lkubb lkubb deleted the vault-ssh branch July 25, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add vault_ssh modules
2 participants