Enhanced CMake install features #112
Conversation
|
@IMFTool Thanks! Will review. Any chance you can rebase against the HEAD of master? |
regxmllib/CMakeLists.txt
Outdated
| project (regxmllibc) | ||
| option(BUILD_SHARED_LIB Bool OFF) | ||
|
|
There was a problem hiding this comment.
cmake already defines BUILD_SHARED_LIBS
There was a problem hiding this comment.
Introduced for pure convenience when using a CMake GUI, from [1]:
This variable is often added to projects as an option() so that each user of a project can decide if they want to build the project using shared or static libraries
[1] https://cmake.org/cmake/help/v3.5/variable/BUILD_SHARED_LIBS.html
There was a problem hiding this comment.
Ok... but it says BUILD_SHARED_LIB and not BUILD_SHARED_LIBS.
There was a problem hiding this comment.
True, I forgot. It's a locally defined name.
regxmllib/CMakeLists.txt
Outdated
| if(BUILD_SHARED_LIB) | ||
| set(LIB_TYPE SHARED) | ||
| if(WIN32 AND NOT CYGWIN) | ||
| set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE) |
There was a problem hiding this comment.
Can't this be set for all platforms... or does it cause problems in cygwin?
There was a problem hiding this comment.
It's being set specifically for WIN32 DLLs. I did not test with cygwin and have it therefore explicitly excluded.
regxmllib/CMakeLists.txt
Outdated
| file(RELATIVE_PATH rel_source ${CMAKE_CURRENT_SOURCE_DIR}/src/main/cpp/com/ ${source}) | ||
| get_filename_component(source_path ${rel_source} DIRECTORY) | ||
| string(REPLACE "\\" "/" source_path_msvc "${source_path}") | ||
| source_group("${source_path_msvc}" FILES "${source}") | ||
| endforeach() | ||
|
|
||
| if(WIN32 AND NOT CYGWIN) | ||
| set(DEF_INSTALL_CMAKE_DIR CMake) |
There was a problem hiding this comment.
Shouldn't this be set by the user?
There was a problem hiding this comment.
The resulting INSTALL_CMAKE_DIR can be edited by the user after configuring the build and before generating the build files. DEF_INSTALL_CMAKE_DIR holds useful default locations.
regxmllib/CMakeLists.txt
Outdated
| EXPORT ${PROJECT_NAME}Targets DESTINATION ${INSTALL_LIB_DIR} | ||
| ) | ||
|
|
||
| foreach ( file ${INC_FILES} ) |
There was a problem hiding this comment.
What is the purpose of this portion of the cmake file?
There was a problem hiding this comment.
Looping through all include files and installing them with their respective full relative path. lines 81 and 82 are debug output and should be removed, though.
merge with upstream
Features: