-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIx GHA issues #12
base: main
Are you sure you want to change the base?
FIx GHA issues #12
Conversation
Add PAT_GITHUB2
Ok, so even after switching to using my GH PAT ( https://github.com/sankaranlab/SCAVENGE/actions/runs/3960552385/jobs/6784854560#step:2:583
|
Ok, so I check
However I did notice some messages during installation:
Wondering if these Originally, I was able to pass all GHA runs on I'd say it's something in |
Actually, nvm about being able to download A thought just occurred to me: @fl-yu are you registered as a member of the sankaranlab GitHub org? |
Thank you Brian for working on this. I think I was a member of https://github.com/sankaranlab, but I am not sure if I was a public member. How can I confirm that? |
I don't know off the top of my head but I'm sure you can find out with a bit of searching. You could also try asking someone who is an admin of sankaranlab to check your permissions. |
I just set myself public while it still does not work. I wonder if this is possibly the case. actions/upload-artifact#232 |
I don't think public/private matters in this case, but what permissions you've been granted does. Can you check this?
|
Hey @fl-yu , just checked up on this and it seems that SCAVENGE is getting through all steps except the very last one on Linux when trying to push to DockerHub: It says something is up with the login/password credentials. Can you double check that:
|
Hooray Brian, this is awesome! I can visit the get started page now https://sankaranlab.github.io/SCAVENGE/articles/SCAVENGE. |
hey @fl-yu just wanted to check in and see if you managed to get the Docker token permissions working? |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 11
Lines ? 181
Branches ? 0
======================================
Hits ? 0
Misses ? 181
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Still seems to be some scoping issues at the Org level for the GITHUB_TOKEN variable. See here for a similar scenario: |
This PR is following up on #10
to resolve any remaining issues with GitHub Actions, and to add my name to the list of contributors.