Make master work #53
Open
Make master work #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add default GOPATH We should use go env as base in future * Refactor * Migrate to go dep * Remove submodules * Cleaning * Add missing def
* Migrate to go mod * update dev-deps * Update deps and dev-deps make update-dev-deps make update-deps * Don't update dependency during build has they are vendored * ... * Use tip not master * disable tip * Activate go 1.10 * Disable go 1.10
golangcibot
reviewed
Dec 2, 2018
Codecov Report
@@ Coverage Diff @@
## old #53 +/- ##
==========================================
+ Coverage 15.2% 56.33% +41.13%
==========================================
Files 2 3 +1
Lines 171 71 -100
==========================================
+ Hits 26 40 +14
+ Misses 144 28 -116
- Partials 1 3 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## old #53 +/- ##
==========================================
+ Coverage 15.2% 56.33% +41.13%
==========================================
Files 2 3 +1
Lines 171 71 -100
==========================================
+ Hits 26 40 +14
+ Misses 144 28 -116
- Partials 1 3 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.