Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silent comments are incorrectly preserved in at-rule values #2263

Closed
nex3 opened this issue Jun 15, 2024 · 0 comments · Fixed by #2266
Closed

Silent comments are incorrectly preserved in at-rule values #2263

nex3 opened this issue Jun 15, 2024 · 0 comments · Fixed by #2266
Labels
bug

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 15, 2024

For example, the SCSS stylesheet

@foo bar // comment

currently produces the CSS

@foo bar // comment;

(Playground link)

This is invalid, and an incorrect interpretation of the silent comment semantics.
@nex3 nex3 added the bug label Jun 15, 2024
nex3 added a commit to sass/sass-spec that referenced this issue Jun 17, 2024
@nex3
Add tests for comments in more expression-like contexts
88ed8a4 
See sass/dart-sass#2263
@nex3 nex3 mentioned this issue Jun 17, 2024
Merged
nex3 added a commit that referenced this issue Jun 17, 2024
@nex3
Parse silent comments in _interpolatedDeclarationValue()
280de8c 
Closes #2263
@nex3 nex3 mentioned this issue Jun 17, 2024
Merged
nex3 added a commit that referenced this issue Jun 17, 2024
@nex3
Parse silent comments in _interpolatedDeclarationValue()
18cd524 
Closes #2263
nex3 added a commit to sass/sass-spec that referenced this issue Jun 20, 2024
@nex3
Add tests for comments in more expression-like contexts (#2000)
e9f7340 
See sass/dart-sass#2263
@nex3 nex3 closed this as completed in 04b6251 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse silent comments in _interpolatedDeclarationValue() sass/dart-sass
1 participant
@nex3