Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate a CSS declaration if its key is interpolated #2036

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Do not validate a CSS declaration if its key is interpolated #2036

merged 2 commits into from
Jul 14, 2023

Conversation

Goodwine
Copy link
Member

Specs: sass/sass-spec#1923
Fixes: #2023

@Goodwine Goodwine mentioned this pull request Jul 12, 2023
Merged
@Goodwine Goodwine requested a review from nex3 July 12, 2023 22:16
nex3
nex3 approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changleog entry. Also, the commit name should use "its" (possessive) instead of "it's" (contraction of "it is"). (Yes it's goofy that "'s" is possessive everywhere else in English but not here, I'm sorry about this language.)

@Goodwine Goodwine changed the title Do not validate a CSS declaration if it's key is interpolated Do not validate a CSS declaration if its key is interpolated Jul 13, 2023
@Goodwine Goodwine merged commit fe7f9a1 into main Jul 14, 2023
45 checks passed
@Goodwine Goodwine deleted the crash-parsed-as-custom-property branch July 14, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If parsedAsCustomProperty is true, value must contain a SassString
2 participants
@Goodwine @nex3