-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write implementation documentation #2042
Conversation
Also rename Dispatcher to CompilationDispatcher for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This documentation is quite useful. I would have loved to have it 2 years ago when I started studying the dart-sass source code instead of having to figure everything by myself (while learning dart at the same time).
@nex3 I would suggest merging this so that the documentation is in the repo (and future PRs might update it if needed) |
I'm hoping @pamelalozano16 has another chance to review. |
* feature.color-4: Poke CI Update link to Node.js releases page (sass#2131) Write implementation documentation (sass#2042) Remove dead code (sass#2129) Add compatibility with Node.js 21.0.0 (sass#2128) Bump lints from 2.1.1 to 3.0.0 (sass#2126) Bump dartdoc from 6.3.0 to 7.0.0 (sass#2118) Cut a release (sass#2120) Update pubspec and changelog for sass/embedded-host-node#257 (sass#2116) Fix crash in browser when running alongside NextJS (sass#2114) Cut another release (sass#2111)
Also rename Dispatcher to CompilationDispatcher for clarity