-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run cli compilations in parallel dart isolates #2078
Conversation
@ntkme The test failure here suggests that we may need to print all messages in the main isolate to ensure they don't end up stepping on one another. |
@nex3 I think the issue is that the internal implementation of |
@nex3 I put up small hack that overrides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind filing an issue against the Dart SDK about print()
not being thread-safe? It seems like the best way to fix that is probably in the SDK itself.
|
This PR enables parallel complications in isolates when running the pure dart version of sass cli.
The goal of this PR is to improve the performance of https://github.com/rails/dartsass-rails, which invokes the cli directly.