Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the output space for color.changeChannels() #2119

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix the output space for color.changeChannels() #2119

merged 1 commit into from
Oct 17, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 17, 2023

No description provided.

@nex3 nex3 requested a review from Goodwine October 17, 2023 20:38
@nex3 nex3 merged commit c848cb4 into feature.color-4 Oct 17, 2023
44 checks passed
@nex3 nex3 deleted the change-channels-space branch October 17, 2023 21:59
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Oct 18, 2023
@jgerigmeyer
Merge branch 'feature.color-4' into color-spaces-js
836bab5 
* feature.color-4:
  [Color 4] Properly serialize missing channels in legacy colors (sass#2115)
  Fix the output space for color.changeChannels() (sass#2119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Goodwine Goodwine Goodwine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nex3 @Goodwine