Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use implementation name dart-sass for VersionResponse #2156

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Use implementation name dart-sass for VersionResponse #2156

merged 3 commits into from
Jan 16, 2024

Conversation

ntkme
Copy link
Contributor

@ntkme ntkme commented Dec 30, 2023

This is mostly cosmetic.

As documented by https://sass-lang.com/documentation/js-api/variables/info/:

For Dart Sass, the implementation name is dart-sass.

The motivation is that I'm enhancing the .info string for ruby host, and I want to use the implementation name returned by the VersionResponse and produce an output like below:

irb(main):001> require 'sass-embedded';
irb(main):002> puts Sass.info;
sass-embedded	1.69.6	(Embedded Host)	[Ruby]
dart-sass	1.69.6	(Sass Compiler)	[Dart]

@nex3
Copy link
Contributor

nex3 commented Jan 2, 2024

I'm a little worried that this is technically a breaking change (although hopefully not one that affects much, since there's only one embedded compiler implementation at the moment). I'm not sure it's strictly an improvement, either; "Dart Sass" is generally a more appropriate name for human presentation. If this is desired, I think I'd be more comfortable adding a new identifier field to the protocol that's required to be a valid CSS identifier and leaving name as human-readable.

@ntkme
Copy link
Contributor Author

ntkme commented Jan 2, 2024

Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, if no one's using it I suppose this works.

@nex3 nex3 merged commit b263a72 into sass:main Jan 16, 2024
34 checks passed
@ntkme ntkme deleted the implementation-name branch January 16, 2024 22:28
lmeysel pushed a commit to lmeysel/dart-sass that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants