Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing ESM export of NodePackageImporter #2177

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add missing ESM export of NodePackageImporter #2177

merged 3 commits into from
Feb 20, 2024

Conversation

jgerigmeyer
Copy link
Contributor

Fixes #2176

jamesnw
jamesnw approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jamesnw jamesnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed this allows importing the NodePackageImporter in a Vite/ESM context.

@nex3 nex3 merged commit 85a932f into sass:main Feb 20, 2024
34 checks passed
@nex3 nex3 deleted the hotfix-missing-pkg-importer-esm branch February 20, 2024 23:00
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nex3 nex3 nex3 approved these changes

@jamesnw jamesnw jamesnw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESM export of NodePackageImporter is missing.
3 participants
@jgerigmeyer @nex3 @jamesnw