-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linux-ia32, linux-arm-musl, and windows-arm64 releases #2265
Conversation
On the other hand, |
Turns out linux-arm-musl was running on the wrong platform. Added another commit to fix that. |
@@ -19,7 +19,7 @@ jobs: | |||
platform: linux/amd64 | |||
- arch: ia32 | |||
runner: ubuntu-latest | |||
platform: linux/386 | |||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Official dart docker image do not have linux/386
support. Use linux/amd64
to build snapshot, as ia32 has no AOT support anyways.
@@ -19,7 +19,7 @@ jobs: | |||
platform: linux/amd64 | |||
- arch: ia32 | |||
runner: ubuntu-latest | |||
platform: linux/386 | |||
platform: linux/amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was ok, but updating just to match the linux-ia32 config.
@nex3 Sorry that my recent commit broken the release CI. This PR should fix it.
https://github.com/sass/dart-sass/actions/runs/9554504858/job/26336030878