Deprecated mixed declarations #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jathak
approved these changes
Jul 2, 2024
jathak
approved these changes
Jul 8, 2024
|
Dartdoc seems to be failing due to dart-lang/dartdoc#3818 |
nex3
changed the title
@nest
|
Confusingly, the page linked to in the warning gives an example that, due CSS specificity rules, renders the same under old and new behaviors. Do we have examples of where new behavior creates differences? |
|
Yes, any example where the nested rule doesn't affect specificity: .example {
color: red;
@media screen {
font-weight: bold;
}
font-weight: normal;
} |
wonda-tea-coffee
added a commit
to wonda-tea-coffee/activeadmin_addons
that referenced
this pull request
Aug 20, 2024
The following deprecation warning was addressed.
```
Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.
More info: https://sass-lang.com/d/mixed-decls
╷
5 │ ┌ label {
6 │ │ display: none;
7 │ │ }
│ └─── nested rule
... │
5 │ ┌ label {
6 │ │ display: none;
7 │ │ }
│ └─── nested rule
... │
9 │ margin-bottom: 5px;
│ ^^^^^^^^^^^^^^^^^^ declaration
╵
vendor/bundle/gems/activeadmin_addons-1.10.1/app/assets/stylesheets/activeadmin_addons/inputs/date-ti
me-picker-filter.scss 9:5 @import
(snip)
```
This warning is due to the following change in dart-sass.
sass/dart-sass#2267
6 tasks
wonda-tea-coffee
added a commit
to wonda-tea-coffee/activeadmin_addons
that referenced
this pull request
Aug 20, 2024
The following deprecation warning was addressed.
```
Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.
More info: https://sass-lang.com/d/mixed-decls
╷
5 │ ┌ label {
6 │ │ display: none;
7 │ │ }
│ └─── nested rule
... │
5 │ ┌ label {
6 │ │ display: none;
7 │ │ }
│ └─── nested rule
... │
9 │ margin-bottom: 5px;
│ ^^^^^^^^^^^^^^^^^^ declaration
╵
vendor/bundle/gems/activeadmin_addons-1.10.1/app/assets/stylesheets/activeadmin_addons/inputs/date-ti
me-picker-filter.scss 9:5 @import
(snip)
```
This warning is due to the following change in dart-sass.
sass/dart-sass#2267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3885
See sass/sass-spec#2002