-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated mixed declarations #2267
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a changelog entry and the sass_api major version should be bumped.
Dartdoc seems to be failing due to dart-lang/dartdoc#3818 |
@nest
Confusingly, the page linked to in the warning gives an example that, due CSS specificity rules, renders the same under old and new behaviors. Do we have examples of where new behavior creates differences? |
Yes, any example where the nested rule doesn't affect specificity: .example {
color: red;
@media screen {
font-weight: bold;
}
font-weight: normal;
} |
The following deprecation warning was addressed. ``` Deprecation Warning: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in `& {}`. More info: https://sass-lang.com/d/mixed-decls ╷ 5 │ ┌ label { 6 │ │ display: none; 7 │ │ } │ └─── nested rule ... │ 5 │ ┌ label { 6 │ │ display: none; 7 │ │ } │ └─── nested rule ... │ 9 │ margin-bottom: 5px; │ ^^^^^^^^^^^^^^^^^^ declaration ╵ vendor/bundle/gems/activeadmin_addons-1.10.1/app/assets/stylesheets/activeadmin_addons/inputs/date-ti me-picker-filter.scss 9:5 @import (snip) ``` This warning is due to the following change in dart-sass. sass/dart-sass#2267
The following deprecation warning was addressed. ``` Deprecation Warning: Sass's behavior for declarations that appear after nested rules will be changing to match the behavior specified by CSS in an upcoming version. To keep the existing behavior, move the declaration above the nested rule. To opt into the new behavior, wrap the declaration in `& {}`. More info: https://sass-lang.com/d/mixed-decls ╷ 5 │ ┌ label { 6 │ │ display: none; 7 │ │ } │ └─── nested rule ... │ 5 │ ┌ label { 6 │ │ display: none; 7 │ │ } │ └─── nested rule ... │ 9 │ margin-bottom: 5px; │ ^^^^^^^^^^^^^^^^^^ declaration ╵ vendor/bundle/gems/activeadmin_addons-1.10.1/app/assets/stylesheets/activeadmin_addons/inputs/date-ti me-picker-filter.scss 9:5 @import (snip) ``` This warning is due to the following change in dart-sass. sass/dart-sass#2267
See sass/sass#3885
See sass/sass-spec#2002