-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Node 18 and 19 support and drop Node 17 #3257
Conversation
@xzyfer should I just drop the Docker/Alpine part for now so this can just land? It's been flaky for awhile on the previous releases anyway. |
My hero |
Looks like x86 should be good in 18.3.0 nodejs/build#2956 and Node 17 is EOL tomorrow. |
@xzyfer would be awesome to have this reviewed soon! :) |
e1bf447
to
d02b7b4
Compare
News about that? |
@nschonni Can you merge this ? thx |
We may need to bump nan version
|
Any update ? For how long we need to wait this PR ? |
+1 |
Hi, any update? |
Hi, any updates about this @nschonni Regards |
+1 |
Would love to see this merged in too. Hoping this package is still maintained. +1 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Now that Node 18 is the active LTS, can we please get this PR some traction? |
Really would like to hear an update on the state of Node 18. currently blocked from progressing without it. |
If not a final release, could a beta release be published with node 18 support? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master should be fixed now and nan and node-gyp have been updated to support node 19.
Awesome ! |
well that took just a brief period of time 😏 |
That's on me. Apologies to everyone waiting on this release, and to @nschonni for disappearing for a little while. Part of our release process for when adding new Node versions I still run manually offline and I was occupied with other priorities. We're looking to better automate the process for future releases. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [node-sass](https://github.com/sass/node-sass) | [`^6.0.0 \|\| ^7.0.0` -> `^6.0.0 \|\| ^7.0.0 \|\| ^9.0.0`](https://renovatebot.com/diffs/npm/node-sass/7.0.3/9.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/node-sass/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/node-sass/7.0.3/9.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sass/node-sass (node-sass)</summary> ### [`v9.0.0`](https://github.com/sass/node-sass/releases/tag/v9.0.0) [Compare Source](https://github.com/sass/node-sass/compare/v8.0.0...v9.0.0) #### What's Changed - Node 20 support by [@​nschonni](https://github.com/nschonni) in [sass/node-sass#3355 ##### Breaking changes - Drop support for Node 14 ([@​nschonni](https://github.com/nschonni)) #### Supported Environments | OS | Architecture | Node | | --- | --- | --- | | Windows | x86 & x64 | 16, 18, 19, 20 | | OSX | x64 | 16, 18, 19, 20 | | Linux\* | x64 | 16, 18, 19, 20 | | Alpine Linux | x64 | 16, 18, 19, 20 | \*Linux support refers to major distributions like Ubuntu, and Debian ### [`v8.0.0`](https://github.com/sass/node-sass/releases/tag/v8.0.0) [Compare Source](https://github.com/sass/node-sass/compare/v7.0.3...v8.0.0) #### What's Changed - Fix binaries being partially downloaded by [@​xzyfer](https://github.com/xzyfer) in [sass/node-sass#3313 - Bump node-gyp and nan for node 19 support by [@​xzyfer](https://github.com/xzyfer) in [sass/node-sass#3314 - feat: Node 18 and 19 support and drop Node 17 by [@​nschonni](https://github.com/nschonni) in [sass/node-sass#3257 ##### Breaking changes - Drop support for Node 12 ([@​nschonni](https://github.com/nschonni)) - Drop support for Node 17 ([@​nschonni](https://github.com/nschonni)) - Set `rejectUnauthorized` to `true` by default ([@​scott-ut](https://github.com/scott-ut), [#​3149](https://github.com/sass/node-sass/issues/3149)) ##### Features - Add support for Node 18 ([@​nschonni](https://github.com/nschonni)) - Add support for Node 19 ([@​nschonni](https://github.com/nschonni)) - Replace `request` with `make-fetch-happen` ([@​CamilleDrapier](https://github.com/CamilleDrapier) [@​xzyfer](https://github.com/xzyfer), [#​3193](https://github.com/sass/node-sass/issues/3193), [#​3313](https://github.com/sass/node-sass/issues/3313)) ##### Dependencies - Bump [email protected] - Bump node-gyp [@​9](https://github.com/9).0.0 - Bump nan@^2.17.0 - Bump sass-graph@^4.0.1 ##### Misc - Bump various GitHub Actions dependencies ([@​nschonni](https://github.com/nschonni)) #### Supported Environments | OS | Architecture | Node | | --- | --- | --- | | Windows | x86 & x64 | 14, 16, 18, 19 | | OSX | x64 | 14, 16, 18, 19 | | Linux\* | x64 | 14, 16, 18, 19 | | Alpine Linux | x64 | 14, 16, 18, 19 | | FreeBSD | i386 amd64 | 12, 14 | \*Linux support refers to major distributions like Ubuntu, and Debian </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
Fixes #3251
Still needs Node Docker image release before this will pass