Skip groups with fewer than default min.cells.group (Fixes #1971) #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamanq
force-pushed
the
yamanq/conserved_min_cells
branch
from
1f1d5cb
to
58fcb40
Compare
|
Hi! Any updates on this? |
|
Thanks for your contribution @yamanq! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current behavior of FindConservedMarkers is the following:
If a group has exactly 0 cells in an Identity, it skips with a warning and no error. If a group has between 1 and min.cells.group (default=3) cells in an Identity, it errors due to ValidateCellGroups. I think a better behavior would be for it to also skip with a warning in this case.
Related issue: #1971
Implementation
I checked for the number of cells in ident.1 before continuing and created a warning for that case.
I have implemented this behavior in the best way I could, but I am not sure if there is a better solution. Thank you.