fix celery worker profile for s3 access #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -504,7 +504,7 @@ def _get_backend_url_and_conf( | |||
| elif backend_protocol == "s3": | |||
| backend_url = "s3://" | |||
| if aws_role is None: | |||
| aws_profile = os.getenv("AWS_PROFILE", infra_config().profile_ml_worker) | |||
| aws_profile = os.getenv("S3_WRITE_AWS_PROFILE", infra_config().profile_ml_worker) | |||
There was a problem hiding this comment.
do we have S3_WRITE_AWS_PROFILE inside the celery forwarder? just want to make sure that this works for (gateway, endpoint builder, celery forwarder, batch job orchestration pod)
There was a problem hiding this comment.
I guess this s3_write_aws_profile means a few things, e.g. in the gateway I think it has to do with some s3 repository for storing llm fine tune jobs, in celery workers it means where completed tasks get written, I think this is fine though since it's all related to s3
guess the perms for this are actually "read, write, maybe list" as opposed to just "write" as well, which probably is fine
There was a problem hiding this comment.
discussed offline. reverting back to profile_ml_worker
seanshi-scale
approved these changes
Oct 19, 2023
yixu34
added a commit
that referenced
this pull request
Oct 23, 2023
saiatmakuri
added a commit
that referenced
this pull request
Oct 23, 2023
saiatmakuri
added a commit
that referenced
this pull request
Oct 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #327
Pull Request Summary
The celery task queue is instantiated with
aws_profileprovided in this line. Tasks were completed but the final state was not written to s3 and silently failed since the profile used was not the one with s3 write permissions. The real issue is only with the Celery forwarder that is created with the wrong profile. Change only for its instantiation.Testing Plan
Create a new deployment in our clusters and launched a batch job. The pods were built correctly and the job successfully completed.