Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR template #341

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Add PR template #341

merged 3 commits into from
Nov 3, 2023

Conversation

song-william
Copy link
Collaborator

@song-william song-william commented Oct 20, 2023 •
edited
Loading

Add a template for Pull Requests in this repo

yixu34
yixu34 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@yixu34 yixu34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest look at PR templates from other OSS projects. Think we'd want a form field for the associated GH issue, if applicable.

@song-william song-william enabled auto-merge (squash) November 3, 2023 21:06
@song-william song-william merged commit cd90549 into main Nov 3, 2023
5 checks passed
@song-william song-william deleted the wsong/add-template branch November 3, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixu34 yixu34 yixu34 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@song-william @yixu34