Fix integration test #383
Merged
Fix integration test #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunfeng-scale
commented
Nov 16, 2023
| @@ -572,7 +572,7 @@ data: | |||
| {{- tuple $env_var | toYaml | nindent 16 }} | |||
| {{- end }} | |||
| {{- end }} | |||
| imagePullPolicy: Always | |||
| imagePullPolicy: IfNotPresent | |||
There was a problem hiding this comment.
@seanshi-scale let me know if this change is okay
There was a problem hiding this comment.
This should be fine, think our image tags are immutable
seanshi-scale
approved these changes
Nov 16, 2023
|
iirc for the endpoints we explicitly load images into minikube at some point, but I'm not sure if the imagePullPolicy on the endpoints is the same |
i'm seeing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Pull policy for these images should be IfNotPresent, otherwise minikube wouldn't be able to load them and fine tune jobs can't start. i'm not sure how finetune integration tests have been passing (maybe we actually pulled the image from minikube?)
Test Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.