fix completions request id #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixu34
reviewed
Dec 7, 2023
model-engine/model_engine_server/domain/use_cases/llm_model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
yixu34
reviewed
Dec 8, 2023
| @@ -1448,7 +1453,7 @@ async def execute( | |||
| ObjectNotAuthorizedException: If the owner does not own the model endpoint. | |||
| """ | |||
|
|
|||
| request_id = str(uuid4()) | |||
| request_id = LoggerTagManager.get(LoggerTagKey.REQUEST_ID) or str(uuid4()) | |||
There was a problem hiding this comment.
Oh I was thinking we'd leave it as None as a fallback, because that's more obviously wrong while not failing the request. uuid4() could end up (continuing to) misleading people.
yixu34
approved these changes
Dec 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
have completions use the same request id as that was generated by the middleware
Test Plan and Usage Guide
local