Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4x sqlalchemy pool size #405

Merged
merged 3 commits into from
Dec 11, 2023
Merged

4x sqlalchemy pool size #405

merged 3 commits into from
Dec 11, 2023

Conversation

yunfeng-scale
Copy link
Collaborator

@yunfeng-scale yunfeng-scale commented Dec 11, 2023

Getting errors like

  File "/workspace/model-engine/model_engine_server/infra/repositories/db_model_endpoint_record_repository.py", line 236, in get_model_endpoint_record
    model_endpoint_orm = await OrmModelEndpoint.select_by_id(
  File "/workspace/model-engine/model_engine_server/db/models/hosted_model_inference.py", line 589, in select_by_id
    endpoint = await session.execute(
.......
sqlalchemy.exc.TimeoutError: QueuePool limit of size 5 overflow 5 reached, connection timed out, timeout 30.00 (Background on this error at: https://sqlalche.me/e/20/3o7r)

apparently there's some traffic spike(?) that caused too many connections to the postgres connection pool

Pull Request Summary

What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@yunfeng-scale yunfeng-scale requested a review from a team December 11, 2023 22:58
@yunfeng-scale yunfeng-scale enabled auto-merge (squash) December 11, 2023 23:23
@yunfeng-scale yunfeng-scale merged commit 5ec6ada into main Dec 11, 2023
5 checks passed
@yunfeng-scale yunfeng-scale deleted the yunfeng-db-pool-size branch December 11, 2023 23:43
@yunfeng-scale yunfeng-scale mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants