handle update endpoint errors #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
song-william
approved these changes
Dec 27, 2023
| @@ -362,13 +362,22 @@ async def execute( | |||
| # infra_state to make sure that after the update, all resources are valid and in sync. | |||
| # E.g. If user only want to update gpus and leave gpu_type as None, we use the existing gpu_type | |||
| # from infra_state to avoid passing in None to validate_resource_requests. | |||
| raw_request = request.dict(exclude_unset=True) | |||
There was a problem hiding this comment.
Good Catch here. I'm guessing the bug here was that pydantic fields with non-falsey defaults were evaluating as being set by the user even if they were not explicitly set in the request?
There was a problem hiding this comment.
yeah, primarily that a user could not specify None for fields for which it's allowed, ie gpu_type
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
ObjectHasInvalidValueExceptionandEndpointResourceInvalidRequestExceptionfor update model endpoint routeEndpointInfraStateNotFoundas an explicit 500Test Plan and Usage Guide
update unit tests