Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using pydantic v2 #429

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Conversation

seanshi-scale
Copy link
Member

@seanshi-scale seanshi-scale commented Feb 3, 2024

Pull Request Summary

Fixes a bug where importing the python client with pydantic 2 installed raises an error. Will publish to pypi after merging the PR.

Test Plan and Usage Guide

Imported client with pydantic 1.10 or pydantic 2 installed, imports succeed.

@seanshi-scale seanshi-scale self-assigned this Feb 3, 2024
@seanshi-scale seanshi-scale marked this pull request as ready for review February 3, 2024 01:29
@seanshi-scale seanshi-scale merged commit 8d8774c into main Feb 3, 2024
5 checks passed
@seanshi-scale seanshi-scale deleted the seanshi/client-pydantic-v2-compat branch February 3, 2024 01:45
@yunfeng-scale yunfeng-scale mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants