Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SC-836587] Pin boto3 and urllib3 versions to fix error in inference image #432

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

edgan8
Copy link
Collaborator

@edgan8 edgan8 commented Feb 6, 2024

Pull Request Summary

The model_engine_integration_tests are broken as is endpoint creation for endpoints where the user does not provide their own docker image. This is because our inference image does not pin some dependencies leading to this known issue with boto3 here. Thus we should pin to a safe version of urllib3 and boto3.

Notably, in the inference image generated right now, the following code crashes. We use the boto3 client when users request return_picked=True

import boto3
s3_client = boto3.client("s3", region_name="us-west-2")
with open("/tmp/file.txt", 'rb') as f:
  s3_client.upload_fileobj(f, "temp-edwardgan-test", "tmp/file")

Test Plan and Usage Guide

I manually confirmed that these changes to the requirements.txt allow the above code to work in the docker image used by our inference endpoint.

Also ran model integration tests in this PR in the models repo: https://github.com/scaleapi/models/pull/8786

Shortcut: sc

@edgan8 edgan8 force-pushed the updateinf branch 3 times, most recently from 70284d8 to 1bfda54 Compare February 6, 2024 18:36
@edgan8 edgan8 changed the title pin boto3 version to try and fix errors Pin boto3 and urllib3 versions to fix error in inference image Feb 8, 2024
@edgan8 edgan8 requested review from song-william and a team February 8, 2024 00:09
@edgan8 edgan8 merged commit 847317e into main Feb 8, 2024
5 checks passed
@edgan8 edgan8 deleted the updateinf branch February 8, 2024 00:18
@edgan8 edgan8 changed the title Pin boto3 and urllib3 versions to fix error in inference image [SC-836587] Pin boto3 and urllib3 versions to fix error in inference image Feb 8, 2024
Copy link

This pull request has been linked to Shortcut Story #836587: model_integration_tests broken on master.

@yunfeng-scale yunfeng-scale mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants