[SC-836587] Pin boto3 and urllib3 versions to fix error in inference image #432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
The model_engine_integration_tests are broken as is endpoint creation for endpoints where the user does not provide their own docker image. This is because our inference image does not pin some dependencies leading to this known issue with boto3 here. Thus we should pin to a safe version of urllib3 and boto3.
Notably, in the inference image generated right now, the following code crashes. We use the boto3 client when users request
return_picked=True
Test Plan and Usage Guide
I manually confirmed that these changes to the requirements.txt allow the above code to work in the docker image used by our inference endpoint.
Also ran model integration tests in this PR in the models repo: https://github.com/scaleapi/models/pull/8786
Shortcut: sc