Add product label validation #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #812003: EGP "product" cost labels are standardized in Launch. |
edgan8
force-pushed
the
edwardgan/productlabels
branch
3 times, most recently
from
92ee0fa
to
0c6159f
Compare
edgan8
requested review from
a team and
song-william
and removed request for
song-william
edgan8
force-pushed
the
edwardgan/productlabels
branch
from
0115934
to
bdbf98e
Compare
saiatmakuri
approved these changes
Feb 23, 2024
| @@ -129,6 +144,7 @@ def validate_labels(labels: Dict[str, str]) -> None: | |||
| if restricted_label in labels: | |||
| raise EndpointLabelsException(f"Cannot specify '{restricted_label}' in labels") | |||
|
|
|||
| # TODO: remove after we fully migrate to the new team + product validator | |||
model-engine/model_engine_server/domain/use_cases/model_endpoint_use_cases.py
Outdated
Show resolved
Hide resolved
edgan8
force-pushed
the
edwardgan/productlabels
branch
from
6d55041
to
b1ab5ed
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This generalizes the logic in llm engine to look for a plugin that can validate both team and product. The goal is to be able to support conventions where the set of products allowed depends on the team label, like the one here doc using a shared plugin between launch and train.
We keep the old code for just checking the team using a plugin around even though it will no longer be necessary so that llm-engine code is backwards compatible with deployments that are not yet using the new extended plugin.
Test Plan and Usage Guide
CI. Manual testing with internal code in https://github.com/scaleapi/models/pull/8924 .
Also note that this PR re-enables some API tests that attempt to create endpoints with invalid team labels.
[SC-812003]