Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change back batch infer GPU util and add tool completion client changes #465

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

yunfeng-scale
Copy link
Collaborator

@yunfeng-scale yunfeng-scale commented Mar 8, 2024

Pull Request Summary

  1. 80% mem usage is probably too conservative. just print mem usage for now
  2. add tool completion client changes

Test Plan and Usage Guide

already deployed

@yunfeng-scale yunfeng-scale requested a review from a team March 8, 2024 02:23
@yunfeng-scale yunfeng-scale changed the title Change back batch infer GPU util Change back batch infer GPU util and add tool completion client changes Mar 8, 2024
@@ -3,6 +3,6 @@
setup(
name="scale-llm-engine",
python_requires=">=3.7",
version="0.0.0.beta25",
version="0.0.0.beta26",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we make the version bump change in pyproject.toml also?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thanks for the catch

Copy link
Member

@seanshi-scale seanshi-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note about bumping the version in the third of three places (pyproject.toml), rest lgtm

@yunfeng-scale yunfeng-scale merged commit bfcfbba into main Mar 8, 2024
5 checks passed
@yunfeng-scale yunfeng-scale deleted the yunfeng-batch-infer-tun branch March 8, 2024 21:05
This was referenced Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants