[Client] Add num_prompt_tokens to the client's CompletionOutputs #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d it breaks on certain frameworks when hosted locally
seanshi-scale
requested review from
ian-scale,
yunfeng-scale,
saiatmakuri and
sam-scale
saiatmakuri
approved these changes
Mar 12, 2024
|
Will push client once merged |
yunfeng-scale
approved these changes
Mar 12, 2024
seanshi-scale
deleted the
seanshi/20240311-reflect-num-prompt-tokens-in-client
branch
This was referenced Mar 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Add a quick
num_prompt_tokensfield to the client's CompletionOutput/CompletionStreamOutput.Originally wanted to add
include_stop_str_in_output, but that requires various server changes to get functional, so I didn't include it here.Test Plan and Usage Guide
Ran against Scale public APIs plus a hosted version.
num_prompt_tokensexists if it's in the http response.