Change LLM Engine base path from global var #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-scale
reviewed
Apr 2, 2024
| DEFAULT_TIMEOUT: int = 10 | ||
|
|
||
| api_key = None | ||
|
|
||
|
|
||
| def get_base_path() -> str: | ||
| return os.getenv("LLM_ENGINE_BASE_PATH", SPELLBOOK_API_URL) |
There was a problem hiding this comment.
nit: since we're changing things with this var, should we rename SPELLBOOK as well?
There was a problem hiding this comment.
We need to keep the Spellbook URL up anyway, and the new APIs also don't support the LLM Engine mirrors that we need, so I think keeping this as Spellbook is still accurate? :)
saiatmakuri
approved these changes
Apr 3, 2024
seanshi-scale
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Needed for SGP code that uses LLM Engine
Test Plan and Usage Guide
Tested with
pip install -e .