-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package update + more docs on dev setup #500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if integration tests pass, looks like some code coverage tests failed? guess we'll need to fix that too
model-engine/model_engine_server/infra/services/live_endpoint_builder_service.py
Outdated
Show resolved
Hide resolved
0e5728b
to
977b7af
Compare
current_model_bundle=model_bundle_3, | ||
owner=test_api_key, | ||
), | ||
high_priority=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this fixture to test the high_priority code path
Pull Request Summary
What is this PR changing? Why is this change being made? Any caveats you'd like to highlight? Link any relevant documents, links, or screenshots here if applicable.
WORKSPACE
env var to be able to run tests locallytype: ignore
and handle type narrowing explicitlyTest Plan and Usage Guide
How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.
Tested pip install + mypy + pytest on a fresh venv using python 3.8.10