Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests for completions #507

Merged
merged 13 commits into from
May 3, 2024
Merged

Conversation

saiatmakuri
Copy link
Contributor

Pull Request Summary

add an integration test that tests a series of completions with its various features

Test Plan and Usage Guide

TEST_USER_ID={{ TEST_USER_ID }} \
BASE_PATH={{ BASE_PATH }} \
TEST_INFERENCE_FRAMEWORK="vllm" \
TEST_INFERENCE_FRAMEWORK_IMAGE_TAG="0.3.3" \
pytest integration_tests -k test_completions

Copy link
Collaborator

@yunfeng-scale yunfeng-scale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for adding this!

Base automatically changed from saiatmakuri/latest-inference-framework-configmap to main May 3, 2024 21:11
@saiatmakuri saiatmakuri merged commit 70d0e77 into main May 3, 2024
0 of 3 checks passed
@saiatmakuri saiatmakuri deleted the saiatmakuri/test-llm-completions branch May 3, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants