Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail checking GPU memory #525

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

yunfeng-scale
Copy link
Collaborator

@yunfeng-scale yunfeng-scale commented May 21, 2024

Pull Request Summary

we don't always have permission to nvidia-smi (e.g. in MIG)

Test Plan and Usage Guide

How did you validate that your PR works correctly? How do you run or demo the code? Provide enough detail so a reviewer can reasonably reproduce the testing procedure. Paste example command line invocations if applicable.

@yunfeng-scale yunfeng-scale requested a review from a team May 21, 2024 22:29
@yunfeng-scale yunfeng-scale merged commit 028d415 into main May 22, 2024
5 checks passed
@yunfeng-scale yunfeng-scale deleted the yunfeng-optional-check-memory branch May 22, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants