Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions for testing & coverage #137

Open
JoshHiles opened this issue Jul 21, 2021 · 7 comments
Open

Actions for testing & coverage #137

JoshHiles opened this issue Jul 21, 2021 · 7 comments
Assignees
Labels

Comments

@JoshHiles
Copy link
Contributor

Description

As a maintainer,
I want testing & coverage ran on PR’s,
So that we are sure the code is ready for release

Acceptance Criteria

  • When a PR is open a action runs
    • Unit tests
    • Coverage
  • The PR status for the unit tests
    • When fails is red & wont allow the PR to be merged
    • When success is green and will allow the PR to be merged
  • The PR Status for coverage
    • When fails is red & wont allow the PR to be merged
    • When success is green and will allow the PR to be merged
@marblekirby
Copy link

We can add coverlet for code coverage.

I can create this github action that will run the unit tests and coverage.

@marblekirby
Copy link

Happy to be assigned this

What i understand that we need:

  • Create new Xunit project on the core-rewrite branch
  • Add new action to run the Xunit tests + coverlet coverage
  • Add new status badge for above action

@JoshHiles
Copy link
Contributor Author

Happy to be assigned this

What i understand that we need:

* Create new Xunit project on the core-rewrite branch

* Add new action to run the Xunit tests + coverlet coverage

* Add new status badge for above action

Sounds good to me, i will create a 3.0.0 branch so you can fork the repo and create PR's against that

@marblekirby
Copy link

grand - do we want to create new project/solution in the core-rewrite/3.0.0 for me to add unit tests.
And then include in this action a build of that new Scientist.Net project before testing and coverage

@JoshHiles
Copy link
Contributor Author

I've pushed up branch 3.0.0
You can remove the code thats already in the scientist folder i forgot i was having a look and pushed it up

@marblekirby
Copy link

sure thank you 👍 👍

@marblekirby
Copy link

marblekirby commented Jul 22, 2021

forked and removed the existing code, installed latest coverlet and XUnit. Will create github action and get PR up for this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants