Moving iterative parameter to a parameter to allow for a version of … #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecers
force-pushed
the
feat/flexible_recompute
branch
from
945a266
to
6d7378d
Compare
hurricane642
approved these changes
May 20, 2022
victorprincipe
force-pushed
the
feat/flexible_recompute
branch
from
0e35cb1
to
564fb61
Compare
…UR where you compute the pi score every n iterations, where if n=0 pi is never recomputed, and the default is n=1
Co-authored-by: Sergei Kliavinek <[email protected]> Update skcosmo/_selection.py Co-authored-by: Sergei Kliavinek <[email protected]>
rosecers
force-pushed
the
feat/flexible_recompute
branch
from
564fb61
to
a141672
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…CUR where you compute the pi score every n iterations, where if n=0 pi is never recomputed, and the default is n=1
This was requested by @eae32 and @victorprincipe in order to reduce the cost of CUR selection by recomputing pi only every so often (basically an accepted loss in performance for a gain in computational efficiency)