Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#255 - negative start index when adding attribute code #294

Open
wants to merge 4 commits into
base: spkl_dev
Choose a base branch
from
Open

#255 - negative start index when adding attribute code #294

wants to merge 4 commits into from

Conversation

CoreySutton
Copy link
Contributor

No description provided.

@CoreySutton
Copy link
Contributor Author

PR for bug #255

scottdurow
scottdurow requested changes Jan 18, 2019
View reviewed changes
Copy link
Owner

@scottdurow scottdurow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - have you run the unit tests?
Perhaps add an addition unit test specifically to test this behaviour.
Also - just a code style point - I try to use type inference where possible - I see you have changed the code to use specific types.

@CoreySutton
Copy link
Contributor Author

Cool beans. I'll run the tests, add some more and fix the code styling :-)

@CoreySutton
Copy link
Contributor Author

I've fixed the code style, created some tests for CodeParser.AddAttribute() and ran the unit tests. All tests with the Unit Test trait passed but all the Integration Tests failed. I assume it's a configuration issue.

@JohnTowgood
Copy link

Hi @scottdurow when will this fix be released? I'm getting the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottdurow scottdurow scottdurow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CoreySutton @JohnTowgood @scottdurow