Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New spkl task to register plugin steps and custom workflow activities from same assembly #372

Open
wants to merge 15 commits into
base: spkl_dev
Choose a base branch
from

Conversation

teppolainio
Copy link
Contributor

This is PR to functionality looked after on issue #366. This PR adds new command pluginandworkflows to spkl.exe. This command simultaneously registers and updates plugin steps and custom workflow activities present on same assembly into CDS. Previously you haven't been able to do this.

If command line argument /e introduced is PR #302 is present then only assembly is updated and registration information of steps and activities is left intact on CDS. I updated also workflow task to use /e flag because otherwise it would've behaved differently from other two registration tasks. I made this change because I felt it was honouring the intent of #302 which was to speed up updates of large assemblies when there were changes only to assembly and not in registrations.

@scottdurow
Copy link
Owner

I'm wondering - the issue is that when updating plugins, the workflow registrations are removed (and visa versa) - perhaps the simplest would be to simply filter on the isworkflowactivity attribute of the PluginTypes - this way we can only remove 'orphaned' registrations if they match the type being registered?

I'm thinking this because it would then avoid having this 'hybrid' task.

Thoughts?

@teppolainio
Copy link
Contributor Author

You mean that you've first registered both plugins and workflows with this new task and then you change task to different one (plugins or workflows)? On this case other half of the registrations will disappear and that's one reason why I think this kind of task is needed. Also updating plugins and workflows in one go would be great. Currently manual operation with pluginregistrationtool is required to achieve that.

@teppolainio
Copy link
Contributor Author

I thought this a bit more. I would like to have possibility to registet assembly and everything in it in one go. This would speed up the process as you would upload assembly only once. This would also reduce possibility of not updating something as you would not have to know you need to run two separate commands. If I got you Scott correctly you want at least that existing plugin and workflow tasks wouldn't delete activities or steps respectively?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants