Fixing #454 nullable object error #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue scottdurow#454. DownloadPluginMetadataTask.AddPluginAttributes would throw an exception on async plugin tasks because the LINQ projection forgot to include the AsyncAutoDelete attribute.
|
@scottdurow Hi Scott, we are using SparkleXrm on our projects and we have been experiencing this issue too, are there any plans to complete this pull request? We need to start using Custom API's so we need to use 1.0.640 of SparkleXrm, but we cannot seem to run spkl instrument on plugins with 1.0.640 as long as this issue is present. |
|
I'll get this PR merged asap |
|
That's very much appreciated! Will the nuget package be updated too? |
|
Yes - that will happen automatically |
|
@scottdurow What's the status on having this PR merged? |
|
Hello! Any chance this will be merged? |
|
Looks like this is still an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #454. DownloadPluginMetadataTask.AddPluginAttributes would throw an exception on async plugin tasks because the LINQ projection forgot to include the AsyncAutoDelete attribute.