Error: Add a status_code method on the Error struct to query the RTSP status code, if any #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottlamb
reviewed
Aug 3, 2023
src/error.rs
Outdated
| @@ -19,6 +19,16 @@ use thiserror::Error; | |||
| #[derive(Clone)] | |||
| pub struct Error(pub(crate) Arc<ErrorInt>); | |||
|
|
|||
| impl Error { | |||
| /// Returns the status code, if the error was generated from a response. | |||
| pub fn status_code(&self) -> Option<rtsp_types::StatusCode> { | |||
There was a problem hiding this comment.
Could you convert this to an u16? rtsp_types isn't part of the public interface now, and I've bumped this dep's version before without worrying about semver. I've actually been tempted to stop depending on it entirely as part of an IO overhaul.
… status code, if any
nemosupremo
force-pushed
the
feat/status-code
branch
from
dca92f6
to
f5c87df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to query the Error status code, for example, if the request was denied because the request was unauthorized due to the username/password being wrong.